NFTX experienced a notice incident on April 15, 2021 affecting NFTX Vault Contracts, lasting 4d 16h. The incident has been resolved; the full update timeline is below.
Affected components
Update timeline
- identified Apr 15, 2021, 04:47 PM UTC
@Gindi alerted an issue with Redeeming Kitties from the Gen-0 Vault at 03:29 GMT 15th April 2021. @javery replied at 07:34 and continued the conversation via DMs. It was identified at 17:00 that the NFTX Contract was calling the `safeTransferFrom()` function which is not supported by the Kitty contract (it is supported on 721). NFTX have hidden the Kitty Funds from the front end minting/redeeming and the Gallery while a patch is being worked on.
- identified Apr 15, 2021, 04:47 PM UTC
We are continuing to work on a fix for this issue.
- identified Apr 16, 2021, 09:26 AM UTC
The contracts are still being worked on to incorporate a fix for redeeming Kitties. All other funds are working as expected.
- identified Apr 16, 2021, 07:35 PM UTC
Changes to the contract have been made and a proposal to make the updates is going through the 24hr Aragon voting process. You can find the updates on the discord at https://discord.com/channels/779073151115984926/791858971316453386/832656386755788839 Once passed the changes will be made, this will be around 6pm GMT 17 April. Once tested, the Kitty funds will be added back to the Gallery and App to allow browsing, minting, and redeeming and the warning will be removed from the site header.
- monitoring Apr 17, 2021, 06:50 PM UTC
Aragon vote has passed, the fund is going through final testing.
- monitoring Apr 19, 2021, 08:11 AM UTC
The first patch covered off one problem but did not solve the redemption issue. Another patch has been put to vote at 0100 GMT 19th April 2021 and will conclude in 24 hours. We expect redemptions to be available for production in approximately 16 hours.
- resolved Apr 20, 2021, 09:44 AM UTC
Aragon vote has passed, contract is updated and the Kitty's can now be redeemed (this has been successfully tested).
- postmortem Apr 20, 2021, 09:44 AM UTC
The Kitty contract was written before the standards of ERC721 had been created, and thus does not have the same calls available on the contract that allowed the redemption of NFTs from the fund which work for typical ERC721. This limitation in earlier NFTs extends beyond Kitties and includes OG’s like CryptoPunks. This is why there are wrappers for CryptoPunks, it allows you to wrap a non standard NFT into a standardised contract which will then work across products built against specifications. In the future, NFTX may look to setup vaults for older projects that will only accept wrapped versions, but for now no official decision has been made. If you have any strong opinions, please mention it in a forum post or through the Discord.